[LUA] Fix Ripper Fang doesn't match wikis #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampitere
changed the title
|
Jimmy's spreadsheet says 1.5 with some attack bonus |
ampitere
force-pushed
the
fix_ripper_fang_incorrect
branch
from
02bb93b
to
d8f18f2
Compare
Definitely bookmarking that doc. Removed the status effect since it doesn't appear to have one. Updated dmgmod value to 1.8 (30% seems fair) as that seems to be how these attack bonuses are calculated for other skills with attack bonuses. Please let me know if there's a better way to add the attack bonus though as I didn't see one. |
| @@ -12,12 +12,11 @@ end | |||
| mobskillObject.onMobWeaponSkill = function(target, mob, skill) | |||
| local numhits = 1 | |||
| local accmod = 1 | |||
| local dmgmod = 2.5 | |||
| local dmgmod = 1.8 | |||
There was a problem hiding this comment.
Suggested change
| local dmgmod = 1.8 | |
| local dmgmod = 1.5 | |
| local info = xi.mobskills.mobPhysicalMove(mob, target, skill, numhits, accmod, dmgmod, xi.mobskills.physicalTpBonus.ATK_VARIES, 1.3, 1.3, 1.3) | |
There was a problem hiding this comment.
Refactored, thanks.
ampitere
force-pushed
the
fix_ripper_fang_incorrect
branch
from
d8f18f2
to
c30d76e
Compare
WinterSolstice8
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Noticed some comment issues on Ripper Fang which led me down the rabbit hole. Wikis seems to have conflicting information but from what I can gather it should be closer to 200% modifier (JP wiki says 150%?) and slashing damage, the additional effect may no longer be a thing but would require retail verification so I've left it in for now.
https://www.bg-wiki.com/ffxi/Category:Raptor
https://www.bg-wiki.com/ffxi/Category:Jug_Pets
https://wiki.ffo.jp/html/23464.html
Steps to test these changes