Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Fix manual sorting doesn't stack items #5698

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 12, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

When manually sorting stackable items it does not stack the items as expected. To fix this we'll expand upon SmallPacket0x029 (item movement) and stacking logic similar to SmallPacket0x03A (sort inventory). Resolves #4929

Steps to test these changes

  1. Turn off auto sorting (Config > Gameplay > Inventory > Sort)
  2. !additem gold_beastcoin 1
  3. !additem gold_beastcoin 2
  4. !additem gold_beastcoin 12
  5. Attempt to manually sort the small stacks together, they should combine
  6. Attempt to manually sort the combined small stack with the large stack, it should move but not stack over max stack size (12)

@claywar claywar merged commit 1b0f77b into LandSandBoat:base May 12, 2024
12 checks passed
@ampitere ampitere deleted the fix_manual_sorting_not_stacking_items branch May 12, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server improperly handling manual client sort/stack packet.
3 participants