Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Battlefields: Sacrificial Chamber #5699

Merged
merged 4 commits into from
May 12, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 12, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Converts all implemented Sacrificial Chamber battlefields to Interaction Framework
  • Fixes issue with Avatar not engaging when gm is enabled
  • Adds Astral Flow IDs for areas 2 and 3 for Jungle Boogeymen (Note: This needs to be refactored away to something without hardcoded ids in the future)

Steps to test these changes

Enter/win/lose/exit all BCNMs

Set avatar group to not spawned

Fix linking due to mob spacing

Add additional spawned check for Wyvern
@claywar claywar force-pushed the interaction/bcnm-sacrificial-chamber branch from c90a8af to e64df37 Compare May 12, 2024 15:09
@claywar claywar merged commit 1f3f7c8 into base May 12, 2024
11 checks passed
@claywar claywar deleted the interaction/bcnm-sacrificial-chamber branch May 12, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants