Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Battlefields: Chamber of Oracles #5706

Merged
merged 5 commits into from
May 13, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 12, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Converts all implemented Chamber of Oracles battlefields to Interaction Framework
  • Adds updateEnmity call for Maat's Wyvern for Shattering Stars (DRG)
  • Adds BCNM exitParameter to replace 32001 event (win) hardcoded value of 1, which is required for Chamber of Oracles to place the player at the correct location depending on the battlefield index

Steps to test these changes

Enter/win/lose/exit all of the converted BCNMs

@claywar claywar force-pushed the interaction/battlefield-chamber-of-oracles branch 3 times, most recently from 667b6b9 to 2c38ec6 Compare May 12, 2024 22:11
@claywar claywar force-pushed the interaction/battlefield-chamber-of-oracles branch from 2c38ec6 to b59f38f Compare May 12, 2024 22:12
@claywar claywar merged commit db6fc28 into base May 13, 2024
11 checks passed
@claywar claywar deleted the interaction/battlefield-chamber-of-oracles branch May 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants