Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix Despoil incorrect message on fail #5718

Merged

Conversation

ampitere
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Despoil currently gives an improper message when it fails due to a stolen always having a value. When a mob has no item to steal or it has already been stolen the stolen variable will be 0.

Before
image

After
image

Steps to test these changes

  1. !changejob 6 99
  2. Find a mob
  3. Attempt to Despoil from it

@ampitere ampitere marked this pull request as ready for review May 13, 2024 17:16
@claywar claywar merged commit 362f740 into LandSandBoat:base May 13, 2024
12 checks passed
@ampitere ampitere deleted the fix_despoil_incorrect_message_on_fail branch May 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants