Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Battlefield: The Celestial Nexus #5719

Merged
merged 1 commit into from
May 13, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 13, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts The Celestial Nexus battlefield to Interaction Framework and updates the 30s engage logic on phase 2 to use a timer as opposed to a 30s bind and 40s silence

Steps to test these changes

Enter/win/lose (cannot exit) battlefield

@claywar claywar force-pushed the interaction/battlefield-celestial-nexus branch from 5a35ef2 to 0f7fccd Compare May 13, 2024 17:23
Fix errors, add orbitals to entity list

Add engage timer, fix ID references

Remove bcnm checks for Celestial Nexus

Remove unused variable
@claywar claywar force-pushed the interaction/battlefield-celestial-nexus branch from 0f7fccd to cd23aca Compare May 13, 2024 17:25
@claywar claywar merged commit e42b3b4 into base May 13, 2024
11 checks passed
@claywar claywar deleted the interaction/battlefield-celestial-nexus branch May 13, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants