Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix Rank 2-3 mission BCNM doesn't award KI on win #5721

Merged

Conversation

ampitere
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The recent BCNM rework missed a small edge case where the win var was changed to 999 instead of 0. As a result, when you win the Rank 2-3 mission BCNM you are not awarded the KI. It doesn't seem like this should cause any issues being 0, at least I did not run into any.

Steps to test these changes

Bastok

  1. !setnation 1
  2. !addmission 1 8
  3. !exec player:setMissionStatus(1, 9)
  4. !zone Horlais Peak
  5. Enter BCNM and win

Windurst

  1. !setnation 1
  2. !addmission 2 8
  3. !exec player:setMissionStatus(2, 9)
  4. !zone Horlais Peak
  5. Enter BCNM and win

If you test both make sure you !completequest before changing over, also !delkeyitem KINDRED_CREST since they both award the same KI.

@ampitere ampitere marked this pull request as ready for review May 13, 2024 19:06
@claywar claywar merged commit 049eeef into LandSandBoat:base May 13, 2024
12 checks passed
@ampitere ampitere deleted the fix_rank_2-3_mission_not_awarding_ki branch May 13, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants