Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deeds field for RoeSparkUpdatePacket to uint16 #5723

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 13, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Deeds field was mistakenly set as uint8 when it should be uint16. Change made to align with packet expectations

Steps to test these changes

Set deeds to 300

@claywar claywar merged commit 455008a into base May 13, 2024
12 checks passed
@claywar claywar deleted the deeds-uint16 branch May 13, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants