Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Shift-proof "C" Zones #5728

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

Frankie-hz
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Shift proof
Crawlers Nest & [S]
Castle Zvahl Keep
Castle Zvahl Baileys
Castle Oztroja [S]
Castle Oztroja
Carpenters Landing
Cape Terriggan
Caedarva Mire

Caedarva Mire
I made a PEALLAIDH_PH_OFFSET call because the IDs were -270 which seemed weird to put there in case an ID shifts. I decided to make the offset the first wild kara which is the PH group instead.

Steps to test these changes

Start server, lotto NMs

TYGER = 17101199,
MAHJLAEF_THE_PAINTORN = 17101200,
EXPERIMENTAL_LAMIA = 17101201,
PEALLAIDH = GetFirstID('Peallaidh'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only request here would be to sort by alpha

@claywar claywar merged commit 13607c3 into LandSandBoat:base May 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants