Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Treasure Chest NPC ID reference in Pso'Xja IDs #5732

Merged
merged 1 commit into from
May 15, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 14, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

image

Pso'Xja has 6 mobs named treasure chest, and the 7th and last one is the NPC, in which GetFirstID would return the first mob. Pulls the entire table and sets to the last value for the expected NPC value, and to resolve the startup warning

Steps to test these changes

No warning, treasure chest NPC appears and works as expected

@Frankie-hz
Copy link
Contributor

I was bound to miss one, thank you! I can go over all the treasure chest to see if I made that mistake somewhere else tonight.

@claywar
Copy link
Contributor Author

claywar commented May 14, 2024

At least for mobs, it appears that Pso'Xja is the only zone that has some named Treasure_Chest. There's a chance that other NPCs might be present though

@claywar claywar merged commit 26a2fb0 into base May 15, 2024
12 checks passed
@claywar claywar deleted the bugfix/psoxja-treasure-chest branch May 15, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants