Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Always store pet ID when saving pet info #5786

Merged
merged 1 commit into from
May 20, 2024

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Apparently zoning with an automaton caused a fire elemental to appear because it's pet ID was set to zero.

Steps to test these changes

Zone with an automaton and keep the automaton.

@MowFord
Copy link
Contributor

MowFord commented May 19, 2024

I think you need more than just the petid though?

I made this PR to resolve the fire elemental when zoning

There was a crash condition that is unrelated to the fix in that PR.

@claywar claywar merged commit 2c27b3f into LandSandBoat:base May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants