Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployer helm chart so that runtime picks the correct docker image #180

Merged
merged 2 commits into from Aug 5, 2023
Merged

Fix deployer helm chart so that runtime picks the correct docker image #180

merged 2 commits into from Aug 5, 2023

Conversation

dave2wave
Copy link
Collaborator

  1. Fix the deployer helm chart so that the runtime picks the proper docker image.
  2. minio-dev.yaml picks a volume that is read only in GKE.
  3. Update instructions

@dave2wave
Fix Deployer Helm Chart
b3816e6 
1. Fix the deployer helm chart so that the runtime picks the proper docker image.
2. minio-dev.yaml picks a volume that is read only in GKE.
3. Update instructions
@dave2wave dave2wave changed the title Fix Deployer Helm Chart Fix deployer helm chart so that runtime picks the correct docker image Aug 5, 2023
@dave2wave dave2wave mentioned this pull request Aug 5, 2023
Closed
eolivelli
eolivelli approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Great

@eolivelli eolivelli merged commit b81ddf5 into main Aug 5, 2023
6 checks passed
@eolivelli eolivelli deleted the fix-deployer-chart branch August 5, 2023 21:14
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@dave2wave
Fix deployer helm chart so that runtime picks the correct docker image (
dd87099 
LangStream#180)

* Fix Deployer Helm Chart

1. Fix the deployer helm chart so that the runtime picks the proper docker image.
2. minio-dev.yaml picks a volume that is read only in GKE.
3. Update instructions

* Yet another place to provide the runtime image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dave2wave @eolivelli