Fix Python Kafka offsets and add tests #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cbornet
commented
Sep 5, 2023
•
cbornet
commented
- Fix committed offset must be last message offset + 1
- Add on_assign/on_revoke
- Add tests
cbornet
force-pushed
the
python-kafka-offsets
branch
from
48b0fe6
to
6606338
Compare
cbornet
force-pushed
the
python-kafka-offsets
branch
from
6606338
to
16a347e
Compare
cbornet
force-pushed
the
python-kafka-offsets
branch
from
80073df
to
0bc1638
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.