Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gateway][cli][controlplane][api] Improvements on startup and new GET Application API without stats #344

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 5, 2023

Summary:

  • currently the "langstream gateway chat" command is very slow at bootstrap
  • one reason is that it gets twice the status of all the pods, this happens because it tries to validate the gateway ids, and it issues a GET /tenant/application that currently returns the full status of the pods

Changes:

  • change the get application endpoint (/tenant/application) to return only the description of the application by default
  • there is a new parameter ?stats=true|false. If you set stats=true then you get the whole application description + metrics + status information

This is a small breaking change in the REST API:
in order to get full metrics you have to add stats=true to the API call
if we already cover the API in the docs, then we have to update it

@eolivelli eolivelli marked this pull request as ready for review September 5, 2023 11:37
@eolivelli eolivelli marked this pull request as draft September 5, 2023 11:37
@eolivelli eolivelli marked this pull request as ready for review September 5, 2023 12:25
@eolivelli eolivelli changed the title [gateway][cli] Improvements on startup [gateway][cli] Improvements on startup and new GET Application API without stats Sep 5, 2023
@eolivelli eolivelli changed the title [gateway][cli] Improvements on startup and new GET Application API without stats [gateway][cli][controlplane][api] Improvements on startup and new GET Application API without stats Sep 5, 2023
@eolivelli eolivelli force-pushed the impl/gateway-latency-improvements branch from 54e22e9 to 5825b4b Compare September 5, 2023 13:39
@eolivelli eolivelli force-pushed the impl/gateway-latency-improvements branch from 5825b4b to d5254d8 Compare September 5, 2023 13:59
@eolivelli eolivelli merged commit 1eaed0f into main Sep 5, 2023
8 checks passed
@eolivelli eolivelli deleted the impl/gateway-latency-improvements branch September 5, 2023 14:47
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants