Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fully asynchronous Sinks and graceful pod shutdown (Java runtime) #354

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 5, 2023

Summary:

  • rework the internal Sink API to be fully async
  • Kafka Topic Sink
  • Kafka Connect Sinks
  • Cassandra Sink
  • Pinecone Sink (not really async)
  • now that everything is async we have to wait for all the messages produced by the Source to be processed before shutting down the process (or the test)

@eolivelli
Copy link
Member Author

This is still work-in-progress.

Now that everything is fully async some tests are flaky because we don't wait for all the messages to be passed to the sink and completely processed

@eolivelli eolivelli changed the title Implement fully asynchronous Sinks Implement fully asynchronous Sinks and graceful pod shutdown (Java runtime) Sep 6, 2023
@eolivelli eolivelli marked this pull request as ready for review September 6, 2023 06:28
@eolivelli
Copy link
Member Author

I have tested the patch manually under some load.
It is safe to commit it

@eolivelli eolivelli merged commit b372b45 into main Sep 6, 2023
8 checks passed
@cbornet cbornet deleted the impl/cassandra-sink-async branch September 7, 2023 09:36
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants