[new feature] Implement Assets - part 1 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
changed the title
nicoloboschi
approved these changes
Sep 6, 2023
| AssetPackage assetPackage = assetManagerPackageLoader.loadPackageForAsset(assetType); | ||
|
|
||
| if (assetPackage != null) { | ||
| log.info("Found the package the agent belongs to: {}", assetPackage.getName()); |
There was a problem hiding this comment.
Suggested change
| log.info("Found the package the agent belongs to: {}", assetPackage.getName()); | |
| log.info("Found the package the asset belongs to: {}", assetPackage.getName()); |
| throw new RuntimeException( | ||
| "Package " | ||
| + assetPackage.getName() | ||
| + " declared to support agent type " |
There was a problem hiding this comment.
Suggested change
| + " declared to support agent type " | |
| + " declared to support asset type " |
| + assetPackage.getName() | ||
| + " declared to support agent type " | ||
| + assetType | ||
| + " but no agent found"); |
There was a problem hiding this comment.
Suggested change
| + " but no agent found"); | |
| + " but no asset found"); |
| return agentCodeProviderProvider; | ||
| } | ||
|
|
||
| log.info("No agent found in the package, let's try to find it among all the packages"); |
There was a problem hiding this comment.
Suggested change
| log.info("No agent found in the package, let's try to find it among all the packages"); | |
| log.info("No asset found in the package, let's try to find it among all the packages"); |
| } | ||
| } | ||
|
|
||
| throw new RuntimeException("No AgentCodeProvider found for type " + assetType); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException("No AgentCodeProvider found for type " + assetType); | |
| throw new RuntimeException("No AssetPackage found for type " + assetType); |
|
thank you @nicoloboschi for your review |
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Summary:
The main use case here is to create tables of vector databases in order to fully set up the application when you deploy it
This is a preliminary PR that builds all the infrastructure to make Assets work.
The next step is to implement the "cassandra-table" AssetManager (and maybe validation at the planner side of the available asset types)