-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Resolve ENV placeholders in secrets.yaml with a bash-like syntax #380
Conversation
README.md
Outdated
1. Export two environment variables containing the OpenAI URL and access key: | ||
``` | ||
export OPEN_AI_URL=xx | ||
export OPEN_AI_ACCESS_KEY=xx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
Export some ENV variables in order to configure access to the database: | ||
|
||
``` | ||
export ASTRA_TOKEN=... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export ASTRA_TOKEN=... | |
export ASTRA_TOKEN=AstraCS:xxxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is worth, the user has to copy/paste from the Astra UI, and we are now using the same terms: token, secret, clientId. Previously we called them username/password with a custom mapping to clientId and secret
``` | ||
export OPENAI_ACCESS_KEY=... | ||
export OPENAI_URL=... | ||
export OPENAI_PROVIDER=azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we default to openai here instead of azure ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have updated it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actully I have removed the whole application, we already have other applications, like the WebCrawler, that do the same things.
It is confusing to have too many examples that perform almost that same things
Export some ENV variables in order to configure access to the database: | ||
|
||
``` | ||
export ASTRA_TOKEN=... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export ASTRA_TOKEN=... | |
export ASTRA_TOKEN=AstraCS:xxx |
Summary:
This patch contains unrelated changes to: