Cli: allow to pass remote file - HTTPS #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicoloboschi
commented
Sep 8, 2023
•
nicoloboschi
commented
- Each value (-app, -i, -s) if it starts with https:// will be downloaded and included in the zip. If the request fails the command fails as well
- plain HTTP is not supported
eolivelli
reviewed
Sep 8, 2023
| if (path == null) { | ||
| return null; | ||
| } | ||
| if (path.startsWith("http://") || path.startsWith("https://")) { |
There was a problem hiding this comment.
"http://" is not more a thing in 2023, we should probably not support it
eolivelli
requested changes
Sep 8, 2023
| .version(HttpClient.Version.HTTP_1_1) | ||
| .GET() | ||
| .build(); | ||
| final Path tempFile = Files.createTempFile("langstram", ".bin"); |
nicoloboschi
changed the title
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.