Add support for a .langstreamignore file #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
commented
Sep 8, 2023
|
|
||
| # This folder holds the libs built for the target | ||
| # and we need it in the package | ||
| !python/lib/ |
There was a problem hiding this comment.
Should we also add java/lib/ to the exclusions ?
There was a problem hiding this comment.
This would be useful,
but we should always not exclude that library, especially if you have "java dependencies"
or we could always "keep" the jars related to the dependency management
There was a problem hiding this comment.
OK. I'll add a rule for Java
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same rules as gitignore.
At the moment, no support for langstreamignore overrides in subfolders.
TIP: set association of .langstreamignore to .gitignore file type in IDE