Allow to return tuples instead of Records in Python agents #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
force-pushed
the
python-records-as-tuple
branch
from
0a38f41
to
56e2239
Compare
|
A couple of questions before committing: |
cbornet
commented
Sep 11, 2023
| @@ -29,31 +29,31 @@ def __init__( | |||
| self, | |||
| value, | |||
| key=None, | |||
| headers: List[Tuple[str, Any]] = None, | |||
There was a problem hiding this comment.
Small breaking change here for consistency.
Only affects if you were using positional args and not named ones.
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the dependency of langstream_runtime module on langstream.