Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource: add static validation for all the known resource types #392

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 11, 2023

Summary:

  • validate as much as possible all the known resource types: datasource (astra, cassandra, pinecone, generic JDBC), vector-database (astra, pinecone, cassandra), openai-configuration, vertex-configuration, hugging-face-configuration
  • the intent is to fail invalid configurations at deploy time

Notes:

  • we are validating resources that are actually used by agents, this allows to have some demo configuration files with empty values: they won't fail the deploy as long as they are not used
  • we cannot connect to the services at deploy time, this is because the actual connection can be performed ONLY from the agent pods, and not from the Control Plane, due to security reasons (agent runners run in special security contexts) and also because the .nar files with the drivers are only available up there

@eolivelli eolivelli marked this pull request as ready for review September 11, 2023 09:32
@eolivelli eolivelli merged commit 965c78e into main Sep 11, 2023
8 checks passed
@eolivelli eolivelli deleted the impl/validate-cassandra-datasources branch September 11, 2023 10:29
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant