Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default provider to OpenAI #401

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Change the default provider to OpenAI #401

merged 2 commits into from
Sep 13, 2023

Conversation

cdbartholomew
Copy link
Member

The default provider should be OpenAI, not Azure. The average user is more likely to have an OpenAI key, which is quite easy to get, than an Azure key. By defaulting to openai there is one less env var to set for in the quick start path.

@cdbartholomew
Copy link
Member Author

For our internal development in Azure, we can configure the model name, so we can make it line up with this value.

@cdbartholomew
Copy link
Member Author

For our internal development in Azure, we can configure the model name, so we can make it line up with this value.

Actually, I take that back. We can configure the model name, but it doesn't accepts dots (.) in the name. This is probably why the names diverge between OpenAI and Azure.

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit c57b35a into main Sep 13, 2023
8 checks passed
@eolivelli eolivelli deleted the default-provider branch September 13, 2023 13:31
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants