Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code storage: Azure Blob integration #408

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Code storage: Azure Blob integration #408

merged 6 commits into from
Sep 14, 2023

Conversation

nicoloboschi
Copy link
Member

@nicoloboschi nicoloboschi commented Sep 14, 2023

Fixes #402

Changes:

  • Added a new code storage implementation compatible with azure blob storage

Helm configuration:

codeStorage:
  type: azure
  configuration:
    endpoint: "https://<your-storage-account>.blob.core.windows.net"
    # only for shared storage account key auth
     storage-account-name: <your-storage-account>   
     storage-account-key: XXXX
     # or
     storage-account-connection-string: "DefaultEndpointsProtocol=https;AccountName=xx;AccountKey=xx;EndpointSuffix=core.windows.net"
     # or using sas tokn
     sas-token: XXXX

by default it creates a container langstream-code-storage, you can change it by setting:

codeStorage:
  configuration
    container: <another-container-name> 

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we could create a langstream-codestorage module
and move the langstream-codestorage-s3 and langstream-codestorage-azure-blob-storage modules there

@nicoloboschi nicoloboschi marked this pull request as ready for review September 14, 2023 08:28
@nicoloboschi nicoloboschi merged commit 6d7f1b1 into main Sep 14, 2023
8 checks passed
@nicoloboschi nicoloboschi deleted the azure-code branch September 14, 2023 08:52
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

langstream deployment issues on Azure AKS
2 participants