Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gateway] Load the Topic Runtime from nar files in order to not pollute the classpath #414

Merged
merged 7 commits into from
Sep 14, 2023
Merged

[gateway] Load the Topic Runtime from nar files in order to not pollute the classpath #414

merged 7 commits into from
Sep 14, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 14, 2023 •
edited
Loading

Summary:

  • remove the kafka-runtime and pulsar-runtime dependencies from the API Gateway, this way we don't import Netty and other stuff into the main classpath
  • this is important for the "docker run" mode, as we have to start the Gateway API Service with the full classapth and the Netty libraries imported by Kafka/Pulsar conflict with the OpenAI libraries

Changes:

  • move NarFileHandler to "core" (shared with Gateway)
  • remove the dependencies
  • allow to configure the path for /app/agents (that contains the .nar files) in the gateway

@eolivelli eolivelli merged commit 519887f into main Sep 14, 2023
8 checks passed
@eolivelli eolivelli deleted the impl/gateway-load-nars branch September 14, 2023 14:53
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@eolivelli
[gateway] Load the Topic Runtime from nar files in order to not pollu…
33cfb1a 
…te the classpath (LangStream#414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eolivelli