Introduce deletion-mode for topics #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Sep 15, 2023
| @@ -147,6 +152,11 @@ public void deployAsset() throws Exception { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public void deleteAsset() throws Exception { | |||
There was a problem hiding this comment.
we can add a "default" method implementation here
There was a problem hiding this comment.
this code is not actually called, I'll follow up in the next pr
| @@ -354,6 +354,7 @@ private Topic buildImplicitTopicForDeadletterQueue( | |||
| new TopicDefinition( | |||
| name, | |||
| creationMode, | |||
| TopicDefinition.CREATE_MODE_NONE, | |||
There was a problem hiding this comment.
this should be the same as the original topic, the same way we do for "creationMode"
| log.info("Topic {} does not exist", topic.name()); | ||
| } else { | ||
| throw e; | ||
| if (topic.deleteMode().equals(TopicDefinition.DELETE_MODE_DELETE)) { |
There was a problem hiding this comment.
topic.deleteMode() may be null for old pipelines, please use Objects.equals()
| } | ||
| } | ||
| default -> log.info("Keeping Kafka topic {}", topic.name()); | ||
| default -> log.info( | ||
| "Keeping Kafka topic {} since creation-mode is {}", |
eolivelli
approved these changes
Sep 15, 2023
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
deletion-modePossible values are
none,deletenoneis the default value.nonemeans to keep the topic when the app is deleteddeletemeans to delete the topic when the app is deletedNote that
deleteworks only if thecreation-modeiscreate-if-not-exists. This is because in that case we know that we can actually manage that topic inside the langstream app.Example: