E2E tests: allow to use an external kafka cluster #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
changed the title
eolivelli
requested changes
Sep 20, 2023
langstream-e2e-tests/pom.xml
Outdated
| @@ -52,6 +52,12 @@ | |||
| <version>${project.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>langstream-kafka-runtime</artifactId> | |||
There was a problem hiding this comment.
please note that this is adding the kafka client dependency and also Kafka Connect with tons of third party deps (like versions of Netty...)
| private static final String SYS_PROPERTIES_PREFIX = "langstream.tests.remotekafka.props."; | ||
| private static final Map<String, Object> ADMIN_CONFIG; | ||
|
|
||
| private org.apache.kafka.clients.admin.Admin admin; |
There was a problem hiding this comment.
are we adding the langstream-kafka-runtime only for this class ?
it is better to add only the kafka-clients jar, and not import all the other dependencies
There was a problem hiding this comment.
Yes initially I wanted to use the topics connection runtime but there's no need now
nicoloboschi
force-pushed
the
e2e-tests-externalkafka
branch
from
410bffb
to
1e02ed6
Compare
eolivelli
pushed a commit
that referenced
this pull request
Sep 20, 2023
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.