CLI: Allow updates to the default profile #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
Sep 20, 2023
| @@ -42,7 +42,8 @@ public class ImportProfileCmd extends BaseProfileCmd { | |||
|
|
|||
| @CommandLine.Option( | |||
| names = {"-u", "--update"}, | |||
| description = "Allow updating the profile if it already exists") | |||
| description = | |||
| "Allow updating the profile if it already exists. Note that the configuration will be overwritten and NOT merged") | |||
There was a problem hiding this comment.
what do you mean with "merged" ?
There was a problem hiding this comment.
I mean that all fields will be overwritten even if they are blank.
If the profile has a token set and you import with the same name but with a blank string, it will override the token with the blank string
There was a problem hiding this comment.
can't we make it more "merge" like ?
it seems awkward,
it should be easy to implement, as you already have the previous version of the profile
There was a problem hiding this comment.
this is "import", you can use update for that
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to update the default profile. This is not very handy. There's no strong reason to block the update
Changes:
updateandimport. It still cannot be deleted