Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webcrawler] Do not fail in case of unknown properties in the JSON file (handle backward compatibility) #469

Merged
merged 3 commits into from
Sep 21, 2023
Merged

[webcrawler] Do not fail in case of unknown properties in the JSON file (handle backward compatibility) #469

merged 3 commits into from
Sep 21, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 21, 2023 •
edited
Loading

Summary:

  • we recently changed the format of the JSON file with the status of the Web Crawler, this broke compatibility and you cannot easily upgrade the application to the newer version
  • with this change in case of a broken JSON file (or with an incompatible format) we ignore the file and start from scratch

For docs:

  • change the default of max-depth to 50

@eolivelli
Copy link
Member Author

FYI @cdbartholomew

@eolivelli eolivelli merged commit e9f9ad2 into main Sep 21, 2023
9 checks passed
@eolivelli eolivelli deleted the impl/webcrawler-compatibility branch September 21, 2023 15:55
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@eolivelli
[webcrawler] Do not fail in case of unknown properties in the JSON fi…
356b3eb 
…le (handle backward compatibility) (LangStream#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees
No one assigned
Labels
needs-doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eolivelli @nicoloboschi