Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vector-db-support] Add support for Milvius.io - part 1 #470

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Sep 21, 2023

Summary:

  • add support for "service=milvus" as "vector-database" resource
  • implement the QueryStepDatasource interface for Milvus
  • implement "milvus-collection" asset
  • implement the MilvusWriter

This is part 1, missing parts:

  • make the sample app work on "docker run"
  • test with the SaaS service
  • add docs

@eolivelli
Copy link
Member Author

it seems that the Milvus SDK imports lots of dependencies, we should fix this or build a dedicate nar file

[INFO] +- io.milvus:milvus-sdk-java:jar:2.3.1:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.24.1:compile
[INFO] | +- org.apache.commons:commons-text:jar:1.6:compile
[INFO] | +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.19.0:compile
[INFO] | | +- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
[INFO] | | - org.apache.logging.log4j:log4j-core:jar:2.19.0:runtime
[INFO] | +- com.squareup.okhttp3:okhttp:jar:4.11.0:compile
[INFO] | | +- com.squareup.okio:okio:jar:3.2.0:compile
[INFO] | | | - com.squareup.okio:okio-jvm:jar:3.2.0:compile
[INFO] | | - org.jetbrains.kotlin:kotlin-stdlib-jdk8:jar:1.7.22:compile
[INFO] | | - org.jetbrains.kotlin:kotlin-stdlib-jdk7:jar:1.7.22:compile
[INFO] | +- org.codehaus.plexus:plexus-utils:jar:3.0.20:compile
[INFO] | +- com.google.code.gson:gson:jar:2.9.1:compile
[INFO] | +- org.jetbrains.kotlin:kotlin-stdlib:jar:1.7.22:compile
[INFO] | | +- org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.7.22:compile
[INFO] | | - org.jetbrains:annotations:jar:13.0:compile
[INFO] | - com.alibaba:fastjson:jar:1.2.83:compile

@eolivelli
Copy link
Member Author

eolivelli commented Sep 22, 2023

I have tried to create a docker image for "milvus lite" but without success.

There is this activity that may help us a lot
milvus-io/milvus-lite#25

@eolivelli eolivelli marked this pull request as ready for review September 22, 2023 16:02
@eolivelli eolivelli changed the title [vector-db-support] Add query support for Milvius.io [vector-db-support] Add support for Milvius.io - part 1 Sep 22, 2023
@eolivelli eolivelli merged commit 891ea71 into main Sep 22, 2023
8 checks passed
@eolivelli eolivelli deleted the impl/support-milvus-1 branch September 22, 2023 16:03
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant