Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor pod: set liveness and readiness probe #475

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

nicoloboschi
Copy link
Member

Currently the executor doesn't have any readiness/liveness probe.
The main problem is that the application status relies on the statefulset ready status. Therefore an app goes into DEPLOYED even if the executor has not started to consume messages yet.
This problem is more evident with the latest improvements on the classpath. The extraction of NAR agents/streaming runtime can take time in low-resource environments.

As user I'd expect that if an app is DEPLOYED, then I can use gateways and get answers in relevant time.

Changes:

  • This solution introduces readiness/liveness probes that check the metrics endpoint. The http server is setup only after all the executor unpackaging has been done and right before creating the streaming consumer.
  • The values are configurable in the deployer configuration

@nicoloboschi nicoloboschi marked this pull request as ready for review September 25, 2023 05:32
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

I would be better to have a dedicated endpoint /healthcheck

But we can change it later

@eolivelli eolivelli merged commit 0119472 into main Sep 25, 2023
8 checks passed
@eolivelli eolivelli deleted the healthcheck-agent branch September 25, 2023 06:26
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants