Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ai-text-completions - OpenAI #477

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

nicoloboschi
Copy link
Member

@nicoloboschi nicoloboschi commented Sep 25, 2023

@nicoloboschi nicoloboschi marked this pull request as ready for review September 25, 2023 11:30
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

I have left some minor feedback


## Deploy the LangStream application
```
#langstream docker run test -app https://github.com/LangStream/langstream/examples/applications/openai-text-completions -s https://raw.githubusercontent.com/LangStream/langstream/main/examples/secrets/secrets.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please move this

# eventually we want to send bigger messages to reduce the overhead of each message on the topic
min-chunks-per-message: 10
prompt:
- "{{% value.question}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a list ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please always use {{{ and not {{ here

List<String> prompt,
StreamingChunksConsumer streamingChunksConsumer,
Map<String, Object> options) {
throw new UnsupportedOperationException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to return a failed Future

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli eolivelli merged commit d59c32a into main Sep 25, 2023
8 checks passed
@eolivelli eolivelli deleted the openai-text-completions branch September 25, 2023 14:25
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants