Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VertexAI parameters #491

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Fix VertexAI parameters #491

merged 4 commits into from
Sep 27, 2023

Conversation

nicoloboschi
Copy link
Member

For VertexAI completions the max-tokens configuration is required. Currently there's a bug and the vertexAI configuration is not converted correctly from the agent to the request json

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nicoloboschi nicoloboschi merged commit 42dc90d into main Sep 27, 2023
8 checks passed
@nicoloboschi nicoloboschi deleted the allow-agent-choose-ai-services branch September 27, 2023 14:17
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants