-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agents] New agent 'dispatch' for message routing #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just not very sure about the empty destination
...ents-flow-control/src/main/java/ai/langstream/agents/flow/FlowControlAgentsCodeProvider.java
Show resolved
Hide resolved
...ts/langstream-agents-flow-control/src/main/java/ai/langstream/agents/flow/DispatchAgent.java
Show resolved
Hide resolved
@nicoloboschi I added support for "action: dispatch|drop" PTAL |
@ConfigProperty( | ||
description = | ||
""" | ||
Destination of the message. If the destination is empty the message is discarded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
name = "Text extractor", | ||
description = | ||
""" | ||
Extracts text content from different document formats like PDF, JSON, XML, ODF, HTML and many others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
routes.forEach( | ||
r -> { | ||
String when = ConfigurationUtils.getString("when", "", r); | ||
String destination = ConfigurationUtils.getString("destination", "", r); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check for blank text and raise error if action == dispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, also on the planner side
Fixes #454
Summary:
This is an example:
Important notes: