Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure blob storage source #546

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Add Azure blob storage source #546

merged 3 commits into from
Oct 9, 2023

Conversation

nicoloboschi
Copy link
Member

Changes:

  • New source azure-blob-storage-source that reads azure blobs
  • The auth properties are the same as the code storage config
  • The properties are idle-time and file-extensions like the s3-source

@@ -0,0 +1,19 @@
# Http Request processor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's based on the http-request branch, Ill put this in draft until we get the other one merged

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The azure part lgtm
But you still have some code from the http request processor


@Override
public Long timestamp() {
return System.currentTimeMillis();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set at instantiation time, otherwise different calls with return different results

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I copied it from S3 source

@nicoloboschi nicoloboschi merged commit 1deef92 into main Oct 9, 2023
7 of 8 checks passed
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants