Add vector database sink config validation and documentation #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Oct 13, 2023
|
|
||
| @Data | ||
| @AgentConfig( | ||
| name = "Solr", |
| Writes data to Solr service. | ||
| The collection-name is configured at datasource level. | ||
| """) | ||
| public class SolrVectorDatabaseSinkConfig |
There was a problem hiding this comment.
The maim class is not VectorDatabaseSink.
I would change here and everywhere to VectorDatabaseWriter (or something like that)
nicoloboschi
force-pushed
the
vector-db-doc
branch
from
32910e6
to
9f02c13
Compare
nicoloboschi
force-pushed
the
vector-db-doc
branch
from
9f02c13
to
286f631
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector databases configuration were not validated and documented because it's per datasource' service
Changes: