Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gateway start from partitioned topics offsets #588

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Oct 15, 2023

No description provided.

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

can we follow up with some unit tests that represent a client that is reconnecting and verify that we are not receiving duplicates and we don't lose massages?

@eolivelli eolivelli merged commit 62bc303 into main Oct 16, 2023
9 checks passed
@eolivelli eolivelli deleted the gateway-pulsar-offset branch October 16, 2023 08:21
@cbornet
Copy link
Member Author

cbornet commented Oct 16, 2023

Yes. There are some tests for Kafka that we can also run on Pulsar. The problem is that atm, there are class loader issues when running them for Pulsar. I'm working on that.

benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants