Add ability to provision persistent disks to agents #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type: "noop" | ||
| resources: | ||
| disk: | ||
| enabled: true |
There was a problem hiding this comment.
enabled ? it seems redundant
There was a problem hiding this comment.
because maybe you want to temporary disable it without removing the configuration.
it is hard to distinguish "not enabled" from nulls that we have in all the code paths that deal with disks, like merging configurations with defaults or handling backward/forward compatibility
nicoloboschi
force-pushed
the
impl/stateful-agents-1
branch
from
723cc70
to
1078f35
Compare
nicoloboschi
changed the title
|
I continued the work:
|
nicoloboschi
changed the title
eolivelli
commented
Oct 24, 2023
dev/start-local.sh
Outdated
| @@ -63,7 +69,7 @@ kubectl apply -f helm/examples/herddb-dev.yaml | |||
| # Start LangStream | |||
| helm repo add langstream https://langstream.github.io/charts | |||
| helm repo update | |||
| helm install langstream langstream/langstream --values helm/examples/local.yaml || helm upgrade langstream langstream/langstream --values helm/examples/local.yaml | |||
| helm install langstream ../langstream-charts/charts/langstream --values helm/examples/local.yaml || helm upgrade langstream ../langstream-charts/charts/langstream --values helm/examples/local.yaml | |||
There was a problem hiding this comment.
we should probably rollback this line
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#590 (comment)