CLI: cache github repository for faster deployments #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make this behavior configurable? |
eolivelli
approved these changes
Oct 19, 2023
eolivelli
approved these changes
Oct 19, 2023
|
|
||
| @Override | ||
| public boolean isDebugEnabled() { | ||
| return true; |
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every time the user specify a github repository for the application/secrets/instance we clone the entire git repository N times. If the user submit the deploy again, the repo is cloned from sctratch again. 99% of use cases are to download from this repo and it takes up to 10 seconds.
Changes:
3-4s vs 1012s on my machine--disable-local-repositories-cacheto fallback to the old behaviourThe downside of this solution is that the repository is stored "forever" in the user home but I don't think it's a real issue.
Another possible issue but very very unlikely is that two deployments happen in parallel and If at the same time the remote branch is updated. I don't think it's a real issue too