CLI UI: start on port 8092 by default #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Oct 25, 2023
| @@ -56,6 +57,12 @@ public class UIAppCmd extends BaseApplicationCmd { | |||
| @CommandLine.Parameters(description = "Application ID") | |||
| private String applicationId; | |||
|
|
|||
| @CommandLine.Option( | |||
| names = {"-p", "--port"}, | |||
There was a problem hiding this comment.
what about "--ui-port" ? "--port" is too generic
There was a problem hiding this comment.
this command is literally
apps ui <appid>
I don't think it's confusing
In fact, in the docker run one, I used --ui-port
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641
Changes:
-pfor apps ui and-upfor docker run