-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Add new agent type python-service #665
Conversation
docker/build.sh
Outdated
clean_cmd="" | ||
if [ "$clean" == "true" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert, this was done on purpose, on some modules is better to clean before building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
new ContainerPortBuilder().withName("http").withContainerPort(8080).build(); | ||
|
||
final ContainerPort portCustomServiceHttp = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always ? shouldn't we do it only if the application has a python-service ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to tweak the CRD (again) in order to do it.
I am not sure it is worth.
a note:
it is not only for "python-service" but for any agent with componentType=SERVICE.
1ed949e
to
c09bca8
Compare
…g LangServe applications (LangStream#665)
Summary:
when you are running in docker the auto-reload feature works out of the box, as soon as you change your Python files the Python daemon is restarted
It is expected that the langstream gateway will act as a proxy to the service, adding:
Running Python application on Kubernetes
LangStream agents are already deployed as a StatefulSet (with persistent disks) and an headless Service.
Deploying an application here allows you to easily leverage all the Kubernetes features, for instance:
Bonus feature added by this PR:
When you declare a Python agent you can easily pass environment variables from secrets:
This PR adds a sample application about how to integrate also with LangSmith