[cli]] updates for multi-os browser for langstream UI #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated the test(s) |
eolivelli
requested changes
Nov 3, 2023
langstream-cli/src/main/java/ai/langstream/cli/commands/applications/UIAppCmd.java
Outdated
Show resolved
Hide resolved
langstream-cli/src/main/java/ai/langstream/cli/commands/applications/UIAppCmd.java
Show resolved
Hide resolved
eolivelli
reviewed
Nov 3, 2023
langstream-cli/src/test/java/ai/langstream/cli/commands/applications/UIAppCmdTest.java
Outdated
Show resolved
Hide resolved
nicoloboschi
requested changes
Nov 3, 2023
langstream-cli/src/main/java/ai/langstream/cli/commands/applications/UIAppCmd.java
Outdated
Show resolved
Hide resolved
eolivelli
requested changes
Nov 3, 2023
langstream-cli/src/test/java/ai/langstream/cli/commands/applications/UIAppCmdTest.java
Outdated
Show resolved
Hide resolved
langstream-cli/src/main/java/ai/langstream/cli/commands/applications/UIAppCmd.java
Show resolved
Hide resolved
eolivelli
changed the title
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main issue was to figure out that the thread needs to wait a bit after processBuilder is called to start the browser and waitfor() can't be used because it doesn't return until the started process completes.
I only tested this out is WSL. Needs to be tested on standard linux, macos and windows.
Added logic to determine OS and spawn a browser process based on the OS