Add gRPC topic producer endpoint - Java side #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
force-pushed
the
python-topic-producer-java-side
branch
from
697dab6
to
5aa62af
Compare
eolivelli
reviewed
Nov 7, 2023
...-agents/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/AbstractGrpcAgent.java
Outdated
Show resolved
Hide resolved
...-agents/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/AbstractGrpcAgent.java
Outdated
Show resolved
Hide resolved
...-agents/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/AbstractGrpcAgent.java
Outdated
Show resolved
Hide resolved
eolivelli
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
LGTM
but a test is failing
Error: Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.424 s <<< FAILURE! - in ai.langstream.agents.grpc.AbstractGrpcAgentTest
Error: ai.langstream.agents.grpc.AbstractGrpcAgentTest.testTopicProducerError Time elapsed: 15.006 s <<< ERROR!
java.util.concurrent.TimeoutException
at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
at ai.langstream.agents.grpc.AbstractGrpcAgentTest.testTopicProducerError(AbstractGrpcAgentTest.java:177)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
d297cb7
to
e5bb22e
Compare
cbornet
force-pushed
the
python-topic-producer-java-side
branch
from
e5bb22e
to
7d0bdcf
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
* Add gRPC topic producer endpoint - Java side * Changes following review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.