MiniLangstream should error out if no NodePort exists for a service (#698) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error handling to the shell script function `start_port_forward` to avoid the current hanging if no *node port* is defined for the service. Doesn't attempt any alternate forwarding (eg kubectl), just gives a moderately helpful message and errors out.
eolivelli
approved these changes
Nov 7, 2023
|
Please fill in https://cla.datastax.com then we can merge your patch. |
nicoloboschi
approved these changes
Nov 8, 2023
|
CLA filed (with my Apache email) |
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
…ream#700) Add error handling to the shell script function `start_port_forward` to avoid the current hanging if no *node port* is defined for the service. Doesn't attempt any alternate forwarding (eg kubectl), just gives a moderately helpful message and errors out. Co-authored-by: Nick Burch <code@gagravarr.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling to the shell script function
start_port_forwardto avoid the current hanging if no node port is defined for the service.Doesn't attempt any alternate forwarding (eg kubectl), just gives a moderately helpful message and errors out.