MiniLangStream enable NodePort if missing for services #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 7, 2023 19:50
Allow specifying the LangStream home directory, via the LANGSTREAM_HOME property (or environment variable). If not specified, continue to use .langstream in the user's home directory, but allow that to be a symlink. Fixes LangStream#697
Add error handling to the shell script function `start_port_forward` to avoid the current hanging if no *node port* is defined for the service. Doesn't attempt any alternate forwarding (eg kubectl), just gives a moderately helpful message and errors out.
If start_port_forward finds that there's currently no Target Port and hence no external URL for a service, it should patch the service definition to enable a dynamically allocated NodePort.
nicoloboschi
approved these changes
Nov 8, 2023
Bash functions return all the stdout, so have the kubectl patch output from enabling the NodePort discarded, so that only the URL is returned.
|
@Gagravarr can you please solve the conflicts ? |
added 3 commits
November 8, 2023 14:04
Also means that if Minikube kicks out an error and suggests a link to their site after reporting the service details, you don't additionally get their github URL coming through!
|
Conflict solved (sorry, took this branch of the wrong one so clashed with other changes) Also one small fix added - if there are multiple URLs found when querying for a service, only the first is taken |
|
Merged! thanks |
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiniLangStream should enable NodePort as required
If
start_port_forwardfinds that there's currently no Target Port and hence no external URL for a service, it should patch the service definition to enable a dynamically allocated NodePort.This fixes #698