Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reorder operation with bassets #4930

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Fix Reorder operation with bassets #4930

merged 1 commit into from
Feb 20, 2023

Conversation

promatik
Copy link
Member

This is a simple fix for the reorder operation with bassets.
It now uses the local file, that should be internalized by the new version of bassets (DigitallyHappy/assets#19 should be merged).

Before merging ...

What is the best place to have these custom javascript/styles?
I placed it in src/resources/assets/libs/jquery.mjs.nestedSortable2.js.

  1. Should we create a bunch of folders to organize everything or throw them all in that folder? js/css folders or libs or anything else?

  1. Did we have more custom files besides nestedSortable2?

@scrutinizer-notifier
Copy link

The inspection completed: 90 new issues

@tabacitu tabacitu merged commit d773683 into bassets Feb 20, 2023
@tabacitu tabacitu deleted the bassets-local-cache branch February 20, 2023 07:24
@tabacitu
Copy link
Member

This is freaking awesome Antonio!

  1. For now I think libs will do just fine. If/when we need to add more files, we'll think about it.
  2. Not that I know of, no... I think this is the only library file we had overridden. But we'll also probably have OTHER files, like completely custom CSS files. Completely custom JS files. That either Backpack provides... or the theme provides. To rephrase... that either the parent theme provides... or the child theme provides.

I've merged this, we're good now. Phiew!!!

@tabacitu
Copy link
Member

PS. The beauty of @basset() is that it allows us, maintainers, to move the JS file in a different directory... and it'd be a non-breaking change. That is freaking great! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants