Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base.php #5500

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update base.php #5500

merged 1 commit into from
Apr 16, 2024

Conversation

vonsofh
Copy link
Contributor

@vonsofh vonsofh commented Apr 16, 2024

Fix some text that better to use

Fix some text that better to use
Copy link

welcome bot commented Apr 16, 2024

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@karandatwani92
Copy link
Contributor

Hey @vonsofh Thanks for the translation fix.

OLD

'handcrafted_by' => 'Buatan tangan oleh', // Handmade by
'powered_by' => 'Dipersembahkan oleh', // Presented by

NEW

'handcrafted_by' => 'Dibuat oleh', // Made by
'powered_by' => 'Didukung oleh', //Powered by

@pxpm how do you find it, can we merge?

@pxpm
Copy link
Contributor

pxpm commented Apr 16, 2024

There are already some inconsistency across some languages.

I think the English version is the "worst". "Handcrafted" feel a lot like sentimentally building. I think it makes sense for @tabacitu that started this project, but for a "company" using the software, "handcrafted" seems like a "lame" word.

In Portuguese this is translated into: Desenvolvido, that the literal translation to english is: Developed not "handcrafted".

About the "Powered by", in Portuguese we have it translated to Distribuido por, literal english translation would be distributed by, but it's more in the sense of brought to you by or sponsored by.

I guess there are some languages where the literal translation doesn't apply and local dialect feels more natural.

Since @vonsofh already contributed a lot of other translations I trust his indonesian more than mine 😄

Thanks @vonsofh and @karandatwani92

@pxpm pxpm merged commit 648c417 into Laravel-Backpack:main Apr 16, 2024
2 checks passed
Copy link

welcome bot commented Apr 16, 2024

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants