-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base.php #5500
Update base.php #5500
Conversation
Fix some text that better to use
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly. Please keep in mind that:
Thank you! -- |
There are already some inconsistency across some languages. I think the English version is the "worst". "Handcrafted" feel a lot like sentimentally building. I think it makes sense for @tabacitu that started this project, but for a "company" using the software, "handcrafted" seems like a "lame" word. In Portuguese this is translated into: About the "Powered by", in Portuguese we have it translated to I guess there are some languages where the literal translation doesn't apply and local dialect feels more natural. Since @vonsofh already contributed a lot of other translations I trust his indonesian more than mine 😄 Thanks @vonsofh and @karandatwani92 |
WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged. You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-) If you want to help out the community in other ways, you can:
Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) -- P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you! |
Fix some text that better to use