Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register field events on UpdateOperation edit form #5521

Merged
merged 4 commits into from
May 16, 2024

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented May 16, 2024

WHY

BEFORE - What was wrong? What was happening before this PR?

It was not possible to register a retrieved model event in fields to run when the entry is retrieved from the database to display on the edit form.

Eg:

CRUD::field('something')->on('retrieved', fn($entry) => $entry->something = json_decode($entry->something))

One would expect that the value of the field would be the json_decoded() version, but this event was never triggered, because the field events were not registered on the update form.

AFTER - What is happening after this PR?

It's now possible to customize model values before the fields attempt to get their respective values by registering a retrieved model event on the field.

HOW

How did you achieve that, in technical terms?

Called the setup of the model events on the edit form endpoint too.

Is it a breaking change?

It shouldn't, as the retrieved events were not working (and that's the only event that happen when the entry is retrieved from the database), I don't think it's possible to break anything.

@pxpm pxpm merged commit 90f1482 into main May 16, 2024
3 checks passed
@pxpm pxpm deleted the register-field-events-on-update-form branch May 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants