Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel v9 support #22

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Laravel v9 support #22

merged 2 commits into from
Mar 19, 2022

Conversation

promatik
Copy link
Member

After barryvdh/elfinder-flysystem-driver#83, Barry did it 馃檶
https://github.com/barryvdh/laravel-elfinder/releases/tag/v0.5.0

Backpack can now fully support Laravel v9

@promatik promatik requested a review from tabacitu March 15, 2022 16:07
@promatik promatik added this to WIP in 馃殌 Backpack v5 (Launch) via automation Mar 15, 2022
@promatik promatik moved this from WIP to Needs Review in 馃殌 Backpack v5 (Launch) Mar 15, 2022
@tabacitu tabacitu requested review from pxpm and removed request for tabacitu March 15, 2022 17:23
@tabacitu tabacitu assigned pxpm and unassigned tabacitu Mar 15, 2022
@tabacitu
Copy link
Member

tabacitu commented Mar 15, 2022

Awesome! @pxpm please double-check? Please consider the 2 scenarios - start from scratch and upgrade from previous version.

@tabacitu
Copy link
Member

I see they dropped support for Laravel 8 and lower in a minor version (0.5), so I think it's ok for FileManager to do the same. I don't think we'll be pushing any updates for L8 and lower specifically in this repo, ever.

composer.json Outdated Show resolved Hide resolved
Co-authored-by: Ant贸nio Almeida <promatik@gmail.com>
@tabacitu
Copy link
Member

tabacitu commented Mar 17, 2022

You know what? Let's launch this as a separate version, that only supports Backpack v5. It'll be easier that way.

@pxpm if you test and give this your thumbs up, I will merge, tag, launch and we'll have ALL Backpack repos supporting L9! 馃挭

Thanks guys!!!

Copy link
Contributor

@pxpm pxpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Tested: Standalone, browse_multiple, browse and ckeditor.

@pxpm pxpm removed their assignment Mar 17, 2022
@pxpm pxpm moved this from Needs Review to Ready to merge in 馃殌 Backpack v5 (Launch) Mar 17, 2022
@tabacitu tabacitu merged commit c500fba into master Mar 19, 2022
馃殌 Backpack v5 (Launch) automation moved this from Ready to merge to Done Mar 19, 2022
@tabacitu
Copy link
Member

Awesoooomee!!! Thanks guys! Merging and tagging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants