Update common_scripts.blade.php (jqueryui/1.10.4 to jqueryui/1.13.1) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqueryui/1.10.4 to jqueryui/1.13.1 Because some of designs were breaking which solved in this new version and elFinder itself used this new jQueryUI.
AfzalSabbir
changed the title
|
Hi @AfzalSabbir! These updates are going to be merged on the new filemanager version which will be supported by bassets 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jqueryui/1.10.4 to jqueryui/1.13.1
Because some of designs were breaking which solved in this new version and elFinder itself used this new jQueryUI.
WHY
BEFORE - What was wrong? What was happening before this PR?
?? Some of designs were breaking ( https://prnt.sc/OtGVbr3V1Gnc )
AFTER - What is happening after this PR?
?? This type of breaking are solved ( https://prnt.sc/ynytaD8uXQSu )
HOW
How did you achieve that, in technical terms?
?? Just changed from jqueryui/1.10.4 to jqueryui/1.13.1
Is it a breaking change or non-breaking change?
?? Yes, it was a large issue, without that we could not close or reopen (pop up) the area ever again!
How can we test the before & after?
?? Just change the version in file
\resources\views\common_scripts.blade.php