Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elFinder dark mode #35

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Add elFinder dark mode #35

merged 8 commits into from
Aug 4, 2023

Conversation

jcastroa87
Copy link
Member

This PR will fix dark mode on elFinder Laravel-Backpack/theme-tabler#103

@jcastroa87
Copy link
Member Author

Hi.

Here are the elFinder problems.

Screenshot 2023-07-24 at 08 26 54

As we speak i try to change background with css, was not possible, because is HTML inside popup. i Find information in this blog https://fvsch.com/transparent-iframes and i try:

<meta name="color-scheme" content="dark" />

thats work for dark:

Screenshot 2023-07-24 at 08 24 38

But create a problem for light:

Screenshot 2023-07-24 at 08 25 35

When i try to delete the meta tag, still have the problem.

Thanks for help.

@jcastroa87 jcastroa87 assigned tabacitu and pxpm and unassigned jcastroa87 Jul 24, 2023
@tabacitu tabacitu assigned jcastroa87 and unassigned tabacitu and pxpm Jul 31, 2023
@jcastroa87
Copy link
Member Author

Hello @pxpm can you test about tinyMCE, is needed to pull this branch and as your instructions "Also if you already have elfinder installed you should delete the elfinder views from your resources/views/vendor/elfinder folder and publish them again with php artisan backpack:filemanager:install" Thanks

@jcastroa87 jcastroa87 assigned pxpm and unassigned jcastroa87 Aug 2, 2023
@tabacitu
Copy link
Member

tabacitu commented Aug 2, 2023

Any chance we can bundle the delete&copy of the blade files into one command, something like php artisan backpack:filemanager:install --force?

@pxpm
Copy link
Contributor

pxpm commented Aug 3, 2023

Hey @jorgetwgroup

This is close to be done but not quite yet.

I notice the following:

  • If I start my page light.
  • Then I switch to dark (without reloading the page)
  • When I open the popup it opens with "light" theme, and then flicks for the "dark".

I think it happens because you used your old solution and didn't implemented the same solution I did in the standalonepopup and elfinder files that fix this.

Laravel-Backpack/theme-tabler#116 now has conflicts too. So I assigned it back to you too.

Let me know.

Cheers

@pxpm pxpm assigned jcastroa87 and unassigned pxpm Aug 3, 2023
@jcastroa87
Copy link
Member Author

Hello @pxpm didnt fail on my side, but in any case i do as you say.

Thanks.

@jcastroa87 jcastroa87 assigned pxpm and unassigned jcastroa87 Aug 3, 2023
@pxpm pxpm merged commit fb5e407 into main Aug 4, 2023
3 checks passed
@pxpm pxpm deleted the elfinder-dark branch August 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants